search

findonflow / find

.find people and NFTs #OnFlow
MIT License
35 stars 6 forks source link

Fix warnings from navid #393

Closed bjartek closed 2 weeks ago

bjartek commented 2 weeks ago

Navid has a tool that checks for exposed permissions. 


Staged Code: https://f.dnz.dev/0x2ceae959ed1a7e7a/0x3e5b4c627064625d_Flomies
❗ Resource NFT is exposing increaseNounce

Address: 0xe8124d8428980aa6, Contract: Bl0x
Staged Code: https://f.dnz.dev/0x2ceae959ed1a7e7a/0xe8124d8428980aa6_Bl0x
❗ Resource NFT is exposing increaseNounce

Address: 0x35717efbbce11c74, Contract: Dandy
Staged Code: https://f.dnz.dev/0x2ceae959ed1a7e7a/0x35717efbbce11c74_Dandy
❗ Resource NFT is exposing increaseNounce```

DoD:
 - we are not exposing increaseNounce, i think it can be private access
highskore commented 2 weeks ago

fixed in https://github.com/findonflow/find/pull/381/commits/0911e8a327fce0fa0ce3a31aec2b27764d9a1bbe