fineanmol / Hacktoberfest2024

Make your first Pull Request on Hacktoberfest 2024. Don't forget to spread love and if you like give us a ⭐️
https://fineanmol.github.io/Hacktoberfest2024/
GNU General Public License v3.0
2.52k stars 7.98k forks source link

issue in Optimization of a Basic Java Queue Implementation #5372

Open ooye-sanket opened 1 year ago

ooye-sanket commented 1 year ago

Lack of Generics: The code could benefit from using generics to make it type-safe and more versatile. Currently, it relies on casting objects, which can lead to runtime errors.

Inefficient Element Removal: The remove method involves shifting elements to the left, which can be inefficient for a large number of elements. Using a circular buffer or linked list would improve removal efficiency.

No Documentation: The code lacks documentation in the form of comments or Javadoc. This makes it less clear for someone reading the code to understand its purpose and functionality.

github-actions[bot] commented 1 year ago

@sanketkalekar Please Star ⭐️ the repo to earn "hacktober-accepted" label for the event. Meanwhile if you want to work on this issue, Please raise the PR and we will review and merge it.

ooye-sanket commented 1 year ago

i have raised the pr to fix these issues please review it and merge it

On Mon, 2 Oct 2023 at 01:17, github-actions[bot] @.***> wrote:

@sanketkalekar https://github.com/sanketkalekar Please Star ⭐️ the repo to earn "hacktober-accepted" label for the event. Meanwhile if you want to work on this issue, Please raise the PR and we will review and merge it.

— Reply to this email directly, view it on GitHub https://github.com/fineanmol/Hacktoberfest2023/issues/5372#issuecomment-1742181697, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAQ2QBBJODA4AIKKPRSIWLLX5HCFLANCNFSM6AAAAAA5ORJ5AM . You are receiving this because you were mentioned.Message ID: @.***>

Zainabohlic commented 1 year ago

Dear @fineanmol I would like to work on this issue. Could you please assign it to me? Regards