fineemb / lovelace-thermostat-card

Thermostat Lovelace card
Other
112 stars 28 forks source link

Fixes for HACS and in main.js #3

Closed chipriley closed 4 years ago

chipriley commented 4 years ago

All files to be installed into HA need to be in a dist folder according to HACS dev docs. Either this or include all of the files in the release. When I installed with HACS, it only installed main.js and deleted styles.js and thermostat_card.lib.js.

Also, there were some syntax issues in main.js also causing issues.

fineemb commented 4 years ago

It still doesn't seem to install styles.js and thermostat_card.lib.js . I've tried, I still have problems.

chipriley commented 4 years ago

Maybe it has to do with it being a release instead of just a commit? Not sure. I know that HACS has been getting updated quite a bit but I’ve never created a plugin deployed through HACS before.

chipriley commented 4 years ago

@fineemb Is the latest release version (1.2.7) good to go? I just don't want to bork my card and I'm running a custom edit of it right now.

fineemb commented 4 years ago

Just fixed the HACS issue

chipriley commented 4 years ago

When I updated to 1.2.8, HACS only installed /dist/main.js and /dist/main.js.gz. No styles.js or thermostat_card.lib.js. I had to wget them. Also had to change the resource reference in ui-lovelace.yaml to include the dist folder.

fineemb commented 4 years ago

need v0.21.5 for HACS