search

finestructure / Arena

A command line tool to create Swift Playground projects with SPM package dependencies
MIT License
685 stars 16 forks source link

Arena doesn't accept branch names with certain characters in them #62

Closed aure closed 4 years ago

aure commented 4 years ago

Even when quoted:

arena https://github.com/AudioKit/AudioKit@branch:v5-develop
arena "https://github.com/AudioKit/AudioKit@branch:v5-develop"
arena https://github.com/AudioKit/AudioKit@branch:"v5-develop"

all give

Error: The value 'https://github.com/AudioKit/AudioKit@branch:v5-develop' is invalid for <dependencies>

whereas

aure$ arena https://github.com/AudioKit/AudioKit@branch:arena
➡️  Package: https://github.com/AudioKit/AudioKit @ branch("arena")

builds the playground.

finestructure commented 4 years ago

Hi Aurelius, thanks for the bug report! Interestingly, it's not the hyphen - I forgot to add numbers to the allowed characters 😅

aure commented 4 years ago

Thanks for addressing out so quickly!