search

fingerpich / jalali-moment

Display, parse, manipulate, validate and convert jalali (Persian, Khorshidi, Shamsi) or Gregorian (Miladi) dates and times.
https://fingerpich.github.io/jalali-moment/
MIT License
435 stars 68 forks source link

Error with existing moment@2.22.1 #39

Closed amirriazi closed 6 years ago

amirriazi commented 6 years ago

First of all thanks for you nice work. When I use in my node project which already dependent to moment@2.22.1 I've got this message: //*** code const shamsi =jmoment('2014/01/24').locale('fa').format('YYYY/MM/DD');

//*** what it shows in console: Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info. Arguments: [0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: 1989/01/24, _f: undefined, _strict: undefined, _locale: [object Object] Error ...........

Thanks again. Mohammad

fingerpich commented 6 years ago

Hi Your welcome Browser support for parsing strings is inconsistent. Because there is no specification on which formats should be supported, what works in some browsers will not work in other browsers. For consistent results parsing anything other than ISO 8601 strings, you should use String + Format. you can use moment('2014/01/24', 'YYYY/MM/DD'); and I will update the document Thank you

amirriazi commented 6 years ago

Thank you again it works now. I appreciate it.