search

fingerprintjs / BotD

Bot detection library that runs in the browser. Detects automation tools and frameworks. No server required, runs 100% on the client. MIT license, no usage restrictions.
https://fingerprintjs.github.io/BotD/main/
MIT License
957 stars 77 forks source link

chore: integrate Broyster #115

Closed fpkamp closed 1 year ago

fpkamp commented 1 year ago

Broyster reduces the pain of BrowserStack Automate testing

fpkamp commented 1 year ago

I don't permissions to add new secrets to GH actions so I had to skip adding tests to the workflow, if someone can help out with those I'll re add that task

Romchela commented 1 year ago

I don't permissions to add new secrets to GH actions so I had to skip adding tests to the workflow, if someone can help out with those I'll re add that task

@xnerhu can you help @fpkamp with it?

xnerhu commented 1 year ago

I don't permissions to add new secrets to GH actions so I had to skip adding tests to the workflow, if someone can help out with those I'll re add that task

I added you to admins.

Finesse commented 1 year ago

@xnerhu Could you please make me an admin temporarily? I'll set special (for GitHub) BrowserStack credentials.

xnerhu commented 1 year ago

@xnerhu Could you please make me an admin temporarily? I'll set special (for GitHub) BrowserStack credentials.

Done

Finesse commented 1 year ago

@xnerhu Could you please make me an admin temporarily? I'll set special (for GitHub) BrowserStack credentials.

Done

@xnerhu I see no effect, I can't add secrets

xnerhu commented 1 year ago

@xnerhu Could you please make me an admin temporarily? I'll set special (for GitHub) BrowserStack credentials.

Done

@xnerhu I see no effect, I can't add secrets

Should be good now.

Finesse commented 1 year ago

@xnerhu Could you please make me an admin temporarily? I'll set special (for GitHub) BrowserStack credentials.

Done

@xnerhu I see no effect, I can't add secrets

Should be good now.

@xnerhu All good, thank you. Now the CI runs BrowserStack behalf GitHub:

image
xnerhu commented 1 year ago

@Finesse @fpkamp Does this pull request fix browserstack timeout, even on all successful tests?

fpkamp commented 1 year ago

@Finesse @fpkamp Does this pull request fix browserstack timeout, even on all successful tests?

@xnerhu in the event that a Browserstack session has been reported as disconnected by Karma we check if all tests were executed and if so, override the disconnect. We're also in touch with Browserstack support about the timeouts.