search

fingerprintjs / BotD

Bot detection library that runs in the browser. Detects automation tools and frameworks. No server required, runs 100% on the client. MIT license, no usage restrictions.
https://fingerprintjs.github.io/BotD/main/
MIT License
954 stars 77 forks source link

fix: Change `enum` behaviour in to emit values on compile stage #134

Closed dj-stormtrooper closed 11 months ago

dj-stormtrooper commented 11 months ago

To fix the compatibility with Pro agent. See more details about the problem here.

dj-stormtrooper commented 11 months ago

Did you check this with Pro agent?

Not yet, I'll check

Finesse commented 11 months ago

@dj-stormtrooper Please confirm that this change solves the problem in Pro agent

dj-stormtrooper commented 11 months ago

@dj-stormtrooper Please confirm that this change solves the problem in Pro agent

Yes, new integration tests are passed (I checked them without changes as well, they capture this error), and checked manually

But I'd check again on staging CDN before deploy just in case (to check full integration)

dj-stormtrooper commented 11 months ago

@dj-stormtrooper Could you please check Pro compatibility again just in case?

@Finesse it's all good

Finesse commented 11 months ago

@xnerhu Good to merge and publish