search

fingerprintjs / BotD

Bot detection library that runs in the browser. Detects automation tools and frameworks. No server required, runs 100% on the client. MIT license, no usage restrictions.
https://fingerprintjs.github.io/BotD/main/
MIT License
954 stars 77 forks source link

Remove the `monitoring` option documentation #146

Closed Finesse closed 9 months ago

Finesse commented 9 months ago

A business decision. DM me if you need more details.

kianandersson commented 7 months ago

👎🏻

Finesse commented 7 months ago

The option is still there, it's just not documented

kianandersson commented 7 months ago

The option is still there, it's just not documented

First of all, it is just bad practice to deliberately try to hide this type of option.

Second, you could at least make sure Your types support the option without @ts-ignore by using unknown instead of never.

xnerhu commented 7 months ago

The option is still there, it's just not documented

First of all, it is just bad practice to deliberately try to hide this type of option.

Second, you could at least make sure Your types support the option without @ts-ignore by using unknown instead of never.

Released 1.7.2. with changed the definitions to export async function load(options?: Record<keyof any, any>)

JuroUhlar commented 7 months ago

Hi @kianandersson, you are right, this change was unintended, here is a PR adding the types and documentation back in, it should be merged shortly: https://github.com/fingerprintjs/BotD/pull/156

Thank you for your feedback!