maintenance - Githubissues

necipallef commented 7 months ago

disabled Flipper according to this comment.
overall improvements on docs
refactored tests

github-actions[bot] commented 7 months ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🔴	Statements	42.4%	53/125
🔴	Branches	22.22%	8/36
🔴	Functions	42.5%	17/40
🔴	Lines	40.5%	49/121

Test suite run success

10 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from a61150faef17b99a7d96679c6100dff0fa1c72a1

Show full coverage report

St|File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s --|------------------------------|---------|----------|---------|---------|----------------------------------------- 🔴|All files | 42.4 | 22.22 | 42.5 | 40.49 | 🟡| [FingerprintJsProAgent.ts](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/FingerprintJsProAgent.ts)| 50 | 40 | 66.66 | 50 |[22-39](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/FingerprintJsProAgent.ts#L22-L39),[69](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/FingerprintJsProAgent.ts#L69) 🟡| [FingerprintJsProContext.ts](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/FingerprintJsProContext.ts)| 75 | 100 | 0 | 75 |[5](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/FingerprintJsProContext.ts#L5) 🟢| [FingerprintJsProProvider.tsx](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/FingerprintJsProProvider.tsx)| 93.33 | 50 | 100 | 93.33 |[43](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/FingerprintJsProProvider.tsx#L43) 🔴| [errors.ts](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/errors.ts)| 16 | 11.11 | 16 | 16 |[8-33](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/errors.ts#L8-L33),[56-249](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/errors.ts#L56-L249),[272-273](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/errors.ts#L272-L273),[319-323](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/errors.ts#L319-L323),[330-364](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/errors.ts#L330-L364),[368](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/errors.ts#L368) 🔴| [index.ts](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/index.ts)| 0 | 0 | 0 | 0 | 🔴| [types.ts](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/types.ts)| 0 | 0 | 0 | 0 | 🟢| [useVisitorData.ts](https://github.com/fingerprintjs/fingerprintjs-pro-react-native/blob/3bb72a466a74dc155bc9bbb5793425dd2fcd4427/src/useVisitorData.ts)| 100 | 100 | 100 | 100 |

necipallef commented 7 months ago

I've just updated Rollup. After running yarn build with the old and new config, the diff are minimal, I've attached screenshots of them. Also, no diff exists for fpjs-pro-react-native.esm.js file.

diff1: https://www.diffchecker.com/PFkKkE8a/ diff2: https://www.diffchecker.com/YwledIDX/ diff3: https://www.diffchecker.com/MshutveO/

fpjs-pro-react-native d ts diff fpjs-pro-react-native cjs js diff