search

fingerprintjs / fingerprintjs-pro-server-api-node-sdk

Node.js wrapper for FingerprintJS Server API
https://dev.fingerprintjs.com/docs/server-api
MIT License
18 stars 3 forks source link

chore: use common logos in readme #87

Closed JuroUhlar closed 8 months ago

github-actions[bot] commented 9 months ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟢 Statements 95.4% 83/87
🟢 Branches 89.74% 70/78
🟢 Functions 100% 20/20
🟢 Lines 95.4% 83/87

Test suite run success

58 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 2bcf75c34bb5e84ddec57bc86f9b0402679467a1

Show full coverage report St|File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s --|--------------------|---------|----------|---------|---------|------------------- 🟢|All files | 95.4 | 89.74 | 100 | 95.4 | 🟢| [index.ts](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/index.ts)| 100 | 100 | 100 | 100 | 🟢| [serverApiClient.ts](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/serverApiClient.ts)| 91.11 | 82.75 | 100 | 91.11 |[32](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/serverApiClient.ts#L32),[36](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/serverApiClient.ts#L36),[47](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/serverApiClient.ts#L47),[91](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/serverApiClient.ts#L91) 🟢| [types.ts](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/types.ts)| 100 | 93.02 | 100 | 100 |[65](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/types.ts#L65),[90](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/types.ts#L90),[93](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/types.ts#L93) 🟢| [urlUtils.ts](https://github.com/fingerprintjs/fingerprintjs-pro-server-api-node-sdk/blob/a2a820cc47a7c4e072b8966ca30af667733e163e/src/urlUtils.ts)| 100 | 100 | 100 | 100 |
JuroUhlar commented 9 months ago

We will break old versions in the npm, just for the info

But it will be fixed with the next NPM release? We can merge this is sync with the next one

ilfa commented 9 months ago

But it will be fixed with the next NPM release? We can merge this is sync with the next one

I meaned previous versions like this

Also for the release you need to rename first commit chore: use common logos in readme -> docs(README): use common logos in readme

github-actions[bot] commented 9 months ago

This PR will create a patch release :rocket:

2.3.4 (2023-11-01)

Documentation

JuroUhlar commented 9 months ago

But it will be fixed with the next NPM release? We can merge this is sync with the next one

I meaned previous versions like this

Also for the release you need to rename first commit chore: use common logos in readme -> docs(README): use common logos in readme

I rebased the branch to keep just the one commit with the proper message. I restored the images so we avoid breaking old Readme versions.

ilfa commented 8 months ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: