finish06 / pyunifi

https://unifi-sdn.ubnt.com/
MIT License
223 stars 99 forks source link

Scripts use dos line endings #38

Open hamiltont opened 5 years ago

hamiltont commented 5 years ago

Brand new install on linux will break as the scripts are using dos line endings. I worked around by manually editing the (pip installed) scripts. I'm not sure what the proper "fix" is - perhaps to have setuptools generate the scripts for the project, which would then generate OS-correct scripts?

Steps to reproduce:

m ~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.2 LTS
Release:    18.04
Codename:   bionic
m ~$ uname -an
Linux media 4.15.0-51-generic #55-Ubuntu SMP Wed May 15 14:27:21 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
~$ sudo pip install -U pyunifi
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/__init__.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 1]) may cause slowdown.
  warnings.warn(warning, RequestsDependencyWarning)
The directory '/home/hamiltont/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/home/hamiltont/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting pyunifi
  Downloading https://files.pythonhosted.org/packages/aa/6e/e4e524081f8e795b8e60e1e46fb30f30fe88f651da65fd77b24ce3032176/pyunifi-2.16.tar.gz
Requirement already satisfied, skipping upgrade: requests in /usr/lib/python2.7/dist-packages (from pyunifi) (2.18.4)
Installing collected packages: pyunifi
  Running setup.py install for pyunifi ... done
Successfully installed pyunifi-2.16
m ~$ unifi-ls-clients
/usr/bin/env: ‘python\r’: No such file or directory

Note: See https://stackoverflow.com/questions/19425857/env-python-r-no-such-file-or-directory for multiple methods to manually fix the issue