search

finish06 / pyunifi

https://unifi-sdn.ubnt.com/
MIT License
226 stars 100 forks source link

Add get_sites and get_sysinfo helpers #9

Closed agauvrit-tis closed 7 years ago

agauvrit-tis commented 7 years ago

I've added these two helpers to retrieve sites and sysinfo.

_getsites helpers have already been proposed as a PR but was a little to intrusive in every functions. I've just reused existing code from @uJIu4 : https://github.com/calmh/unifi-api/pull/39#issuecomment-231037978

_getsysinfo is usefull to retrieve Unifi controller name/FQDN and Unifi controller version, etc.

Many usefull API functions from php class UniFi-API-browser could be backported to python

finish06 commented 7 years ago

Thank you for the contribution. I will review it in the coming days.

agauvrit-tis commented 7 years ago

I've made the changes, will you be able to merge changes ?

How can I safely contribute to the project ? Do I have to make a PR for each function I wish to add ?

finish06 commented 7 years ago

@agauvrit-tis Yes, that is the best approach. Just do a PR and I will then merge once reviewed.

Thank you for the contribution!