finity69x2 / fan-control-entity-row

Provides a means to show a compact graphical control row for 2 or 3 speed fans in Home Assistant
68 stars 27 forks source link

Support for changing order of turn_on and set_speed #12

Closed tomlevels closed 4 years ago

tomlevels commented 4 years ago

For my fan, the current setting of speed is not working. In your code, first a set_speed is sent, and then a turn_on. This is not working for my fan: it first needs the turn_on and then the set_speed. Is it possible to add an option for this?

finity69x2 commented 4 years ago

@tomlevels

I've got the code switched around but I don't necessarily want to do a full release with it until I know that it will work for you (and others...)

can you test the new code for me with your setup and let me know if it works?

I put the updated code into the dev branch if you want to install that and test it.

tomlevels commented 4 years ago

I tried your new code and it works fine for my fan. Of course I cannot be sure it works for everybody, but if it does not, maybe it could be made in to an option in the configuration

finity69x2 commented 4 years ago

@tomlevels

Ok thanks for testing it for me.

I've tested it on my two versions of iFan's and it works for both of mine as well.