search

finity69x2 / fan-control-entity-row

Provides a means to show a compact graphical control row for 2 or 3 speed fans in Home Assistant
68 stars 27 forks source link

Off Button does nothing #29

Closed wotelljm closed 4 years ago

wotelljm commented 4 years ago

The off button no longer works. I am using a BOND but the "off" event does work with scripts or sending the event manually.

raz0rf0x commented 4 years ago

I noticed an issue with that in relation to using the BOND fan control integration. I brought it up in this issue.

I believe it is related to this part of the .js:

    setSpeed(e) {
        const speed = e.currentTarget.getAttribute('name');
        if( speed == 'off' ){
            this.hass.callService('fan', 'turn_off', {entity_id: this._config.entity});
            this.hass.callService('fan', 'set_speed', {entity_id: this._config.entity, speed: speed});
        } ...

By commenting out the this.hass.callService('fan', 'set_speed', {entity_id: this._config.entity, speed: speed}); line I was able to get the "off" command to work.

I would suggest a feature request to be able to turn off "set_speed" with off for integrations that don't like that.

raz0rf0x commented 4 years ago

I have submitted a PR: https://github.com/finity69x2/fan-control-entity-row/pull/30

raz0rf0x commented 4 years ago

@wotelljm I just tested the https://github.com/home-assistant/core/pull/39488 fix and it resolves this problem even without the PR I submitted above. Hopefully it'll be in the next HA update.

The code maintainer for the BOND integration has updated it to correctly respond to a fan speed of "off". This seems to allow this custom component to work normally.

finity69x2 commented 4 years ago

Then I assume the PR is no longer needed?

raz0rf0x commented 4 years ago

Then I assume the PR is no longer needed?

Not to fix this issue, no. I resolved it with the BOND integration maintainer If there isn't a use case for anything else it can be ignored.

finity69x2 commented 4 years ago

Ok, thanks for the info. I'll close it.

wotelljm commented 4 years ago

Correct. I had the old implementation of the Bond integration installed. It was installed manually through the custom components and manually downloaded files. After removing this and installing the new integration through the "integrations" mechanism it is working now.

On Tue, Sep 8, 2020 at 5:13 PM finity69x2 notifications@github.com wrote:

Ok, thanks for the info. I'll close it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/finity69x2/fan-control-entity-row/issues/29#issuecomment-689163997, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMFPKGBFPIYQAYPUX4C2UDSE2T77ANCNFSM4QPGKEXA .