search

finity69x2 / nws_alerts

An updated version of the nws_alerts custom integration for Home Assistant
86 stars 29 forks source link

Fix tests #28

Closed firstof9 closed 2 years ago

firstof9 commented 2 years ago

Also added typing to _get_zone_list

codecov-commenter commented 2 years ago

Codecov Report

Merging #28 (4d58d08) into master (45c4a41) will decrease coverage by 33.74%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #28       +/-   ##
===========================================
- Coverage   89.16%   55.41%   -33.75%     
===========================================
  Files           4        4               
  Lines         323      323               
===========================================
- Hits          288      179      -109     
- Misses         35      144      +109
Impacted Files Coverage Δ
custom_components/nws_alerts/config_flow.py 60.81% <100.00%> (-25.68%) :arrow_down:
custom_components/nws_alerts/sensor.py 64.86% <100.00%> (-17.57%) :arrow_down:
custom_components/nws_alerts/__init__.py 43.67% <0.00%> (-48.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0bc5a9f...4d58d08. Read the comment docs.

firstof9 commented 2 years ago

I'll add a better mock for the function later. This is more of a quick fix.