finity69x2 / nws_alerts

An updated version of the nws_alerts custom integration for Home Assistant
84 stars 29 forks source link

Open up commits? #55

Closed mdecourcy closed 1 year ago

mdecourcy commented 1 year ago

Hi there, I was having issues with the NWS_Alerts tab. Wanted to commit and create a PR with my changes but was met with a 403 forbidden. Thanks for providing this integration!

finity69x2 commented 1 year ago

I'm not sure what you mean but you can open a PR if you want.

you just can't commit the changes yourself.

what is the issue you are having?

mdecourcy commented 1 year ago
image

Might just be an issue with my locally saved creds on this machine, I'll check after I wrap up at work

jarrodsfarrell commented 1 year ago

@mdecourcy You're trying to push directly to someone else's repo you do not have access to. You have to fork, clone your fork, branch, commit, push, then PR.

The flow I use to committing and PRing to someone else's project is the following:

This is my flow, but I know there's quicker ways via GitHub's CLI and different ways to begin a PR. Explore around.

You will occasionally have to update your fork and there's a way to do it on the web, but typically I set up another remote on my local repo—like upstream—, switch to your fork's main, git fetch upstream, git merge upstream/main or something of that effect then git push. Ideally it should fast-forward, but if it does something else or fails then the owner did a force push that broke the history or you have local commits that are conflicting.

mdecourcy commented 1 year ago

Ah I see, my mistake! First attempt at open source contributions. I'm used to just feature branching and PRing at work. I'll fork and make a PR now.

jarrodsfarrell commented 1 year ago

@mdecourcy No problem, and that would be a valid way to do a PR as well on repos you have access to as well.