finity69x2 / nws_alerts

An updated version of the nws_alerts custom integration for Home Assistant
84 stars 29 forks source link

Possible Variable issue - just FYI #60

Closed regularguy01 closed 1 year ago

regularguy01 commented 1 year ago

Looks like they changed the way the Var integration works?
https://github.com/Wibias/hass-variables/issues/35

Will this effect the Alerts history function?

regularguy01 commented 1 year ago

I see you already posed about it.

finity69x2 commented 1 year ago

unfortunately, yes.

As you saw I'll lock my variables integration at the last version that uses the variables domain.

I may try out the newer variables version on my test setup so I can update the package for the newer version for those that have updated. But I can't give a timeframe for when I might get to it.

regularguy01 commented 1 year ago

unfortunately, yes.

As you saw I'll lock my variables integration at the last version that uses the variables domain.

I may try out the newer variables version on my test setup so I can update the package for the newer version for those that have updated. But I can't give a timeframe for when I might get to it.

If you like I can try and update and test it. Based on my reading they call it a sensor now instead of variable. You also might just try using input_text helpers instead.

finity69x2 commented 1 year ago

Sorry, I've been pretty busy lately and haven't had a chance to even think about this issue yet.

but yes, I guess I should update the package to use the non-variable domain options.

I've always liked the variable integration for it's ability to have custom attributes that you could set via a service call. the new so-called variables (but not really now since it's just a new custom sensor) can still do that too so it's not a total loss.

I just need to find the time to decide which direction to go and then re-code the package to that standard.

regularguy01 commented 1 year ago

No worries.