search

finity69x2 / nws_alerts

An updated version of the nws_alerts custom integration for Home Assistant
84 stars 29 forks source link

Please consider adding 'onset' as an attribute #67

Closed kidhasmoxy closed 1 month ago

kidhasmoxy commented 1 year ago

The integration is fantastic and I'm using it for automations, but I've noticed that we'll often times have an alert long before the event in question. This is especially common for "watch" alerts.

I use this integration to trigger charging up my batteries to full and also certain other safety related items. Sometimes the onset is set as 24-36 hours after the alert starts, even when the alert is marked as severe. With the onset, I could decide when to start filling the batteries and also trigger certain automations for closer to the event vs the 1-2 days before where it's still sunny.

jhemak commented 5 months ago

I was about to suggest the same and then came across this. +1 for the suggestion, please. I would also like to suggest adding "ends" as I am seeing examples where the "ends" value and what is currently provided as "event expires" do not match. Thank you!

finity69x2 commented 1 month ago

I'll get this added soon. Sorry it's taken so long to implement.

finity69x2 commented 1 month ago

Done

jhemak commented 1 month ago

Are you open to also adding "ends" as suggested above? I have added it to mine manually but have to re-do the change every time you release an update to the integration.