finity69x2 / nws_alerts

An updated version of the nws_alerts custom integration for Home Assistant
84 stars 29 forks source link

fix-prevent-frequent-state-change-on-api-glitch #71

Open EdLeckert opened 10 months ago

EdLeckert commented 10 months ago

Fix for Issue #70.

Addresses momentary inability of the NWS Alerts API to respond with valid data, which is a frequent occurrence. When this happens, the entity from the integration becomes unavailable, which can cause unnecessary and annoying alert notifications in some HA installations.

The suggested fix is to NOT update the entity's state when this error occurs. All other behavior remains unchanged, including the reporting of all other types of errors.

If the API remains in this failed state for an extended period of time, the data in the entity can become stale. However, I believe it is better to present the latest available alert data, rather than no data at all.

As to the type of log message reported, this is such a frequent issue with no action necessary on the part of the user that after some reflection, I decided to log it as type debug.