finmath / finmath-lib

Mathematical Finance Library: Algorithms and methodologies related to mathematical finance.
Apache License 2.0
488 stars 168 forks source link

MertonModelDescriptor + adjstuments in MertonModel Monte Carlo #70

Closed AlessandroGnoatto closed 5 years ago

AlessandroGnoatto commented 5 years ago

What is this PR for?

Add MertonModelDescriptor extend some factories. Introduce discount curves in the Merton Model class

What type of PR is it?

Integrate the Merton Model in the structure allowing for separation of model and implementation.

Todos

I noticed that Merton Model is parametrized in terms of doubles while Heston model in terms of RandomVariable... should we have more consistency here?

What is the related issue?

Missing descriptor for the Merton Model. Missing discount curves in the Monte Carlo implementation of the Merton Model.

How should this be tested?

Screenshots

Questions:

Does the licenses files need update? NO

Are there breaking changes for older versions? NO

Does the change require additional documentation? NO

AlessandroGnoatto commented 5 years ago

Just a quick note: I did some refactoring work on all Fourier models. There were a lot of inconsistencies between different classes. What I saw: