finn-no / Finjinon

Custom iOS camera optimized for taking a sequence of photos quickly and/or selecting from an image picker
MIT License
58 stars 16 forks source link

Allow network access for icloud photo library. Add custom activity indicator for uploads. #13

Closed PWFinn closed 7 years ago

PWFinn commented 7 years ago

What?

AssetResolver has been updated with PHImageRequestOptions().isNetworkAccessAllowed = true to allow network access when retrieving full quality photos from iCloud Photo Library.

PhotoCaptureViewController has got a new imagePickerWaitingForImageDataView: UIView? property which (if it isn't nil) is overlaid by presentImagePickerTapped; to serve a custom view containing for example an activity indicator.

Tip: The custom view could also contain e.g. a button with code to reference back to PhotoCaptureViewController.imagePickerWaitingForImageDataView?.removeFromSuperview() to allow the user to hide it while upload continues in the background.

Why?

Users experienced that some photos didn't get uploaded when selected, without any error or explanation given. This was probable due to a missing network-access permission in relation to iCloud Photo Library.