Closed aalemayhu closed 5 years ago
Hmm, I forgot to fix urls for tags that have spaces in them. Will trying using slugify
and drop the work in progress prefix later.
Dropping the slugify
, the browser encodes the URLs properly. Tested via localhost with desktop Safari and Chrome also on iOS Safari.
Thanks Alexander!
@3lvis thanks for merging this, but found it actually breaks stuff. I will follow up with a new pull request unless you want to revert all the changes. I have setup a own staging area on http://tech.finn.xdp.no
to verify it actually works this time and will open pr after testing my changes properly.
Thanks.
Actually nothing new broke, it was just my local setup that was rendering the page different. The links still don't work though, opened pr with potential fix https://github.com/finn-no/tech.finn.no/pull/51
but still not sure if fixed on tech.finn.no.