search

finnbechinka / faceit-leetify-rating

A small script that displays leetify ratings on FACEIT
GNU General Public License v3.0
7 stars 0 forks source link

Would it be possible to modify this to add leetify rating to the player summary in the match room before a game? #18

Open callmeaderp opened 1 year ago

callmeaderp commented 1 year ago

Hey, novice programmer here. I was wondering if it was possible to modify this addon to ALSO add the leetify rating of all available users in the drop down below their profiles before a game starts. I think that might be sending too many requests but again I am very new in this area of prgraming so I don't really know. I don't want to take a crack at this only to find out in the next couple weeks that it isn't possible.

finnbechinka commented 1 year ago

Yes, it should be possible to display leetify ratings there, but I'm not sure if you would need to send an excessive amount of API calls don't really think so tough. Maybe about 10 requests send to leetify (one per player) and maybe one faceit call. I don't think that would be all that bad, but I'm also not sure about my count since I forgot about the APIs because it has been a minute since I worked on this.

Just checked, and I'm using this function to get the leetify rating for a user: https://github.com/finnbechinka/faceit-leetify-rating/blob/8059676722e16195cf73f01bbd02d6ef1d470ad9/faceit-leetify-rating.user.js#L82 From skimming over it: looks like it's going to be about ~3 requests per user on average (5 max for one user, worst case) I personally still don't think it's a big deal (especially considering that visiting just one match page on leetify does 130+ requests, navigating on the match page increases this significantly, so 1 person checking out a single match normally on leetify will create > 1000 requests) and I think this is the best we can do considering I'm basically misappropriating API calls that are not directly intended for this use case.