componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details

tangrammer commented 4 years ago

Hi @finnfiddle :)

We've updated react to last version on akvo-lumen client and now we get this problem that I'd bet that comes from your lib 🤔

Move code with side effects to componentDidMount, and set initial state in the constructor.
Rename componentWillMount to UNSAFEcomponentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: _class

... Please update the following components: Text

I tried to run npx react-codemod rename-unsafe-lifecycles in your lib but the results are weird 😬

any ideas??

have a good day!

finnfiddle commented 4 years ago

Hi @tangrammer nice to hear from you. Thanks for reporting Ill take a look into it

finnfiddle commented 4 years ago

hey I looked into it but couldnt reproduce. Please could you provide a reproducible example/repo and I will sort it out. thanks

finnfiddle / potion