search

finnfiddle / words-to-numbers

JS library to convert textual words to numbers with optional fuzzy text matching
MIT License
248 stars 57 forks source link

allow mixed numbers #12

Closed syavorsky closed 7 years ago

syavorsky commented 7 years ago

@finnfiddle would be happy if you consider this pull request. Just a little addition to the awesome lib you already have

finnfiddle commented 7 years ago

Hi yavorskiy, thanks for this contribution - however I recently refactored pretty much all the code and so there are major conflicts now which I dont have time to resolve myself. I have added the "dot" functionality though in d708d1be3976020b71a87e601023d3b5b2092569 (v1.3.0 on npm) so you can use that. You are welcome to make another PR if you can resolve the conflicts - maybe its a good idea to make a few more tests for it though and try see if we can find any edge cases. thanks

syavorsky commented 7 years ago

no probs