search

finnfiddle / words-to-numbers

JS library to convert textual words to numbers with optional fuzzy text matching
MIT License
248 stars 57 forks source link

Replacing clj-fuzzy library with talisman #44

Open csp197 opened 12 months ago

csp197 commented 12 months ago

This PR replaces the clj-fuzzy library with the talisman library. I believe this should resolve the error seen in #43

The talisman library offers two separate jaro based metrics, jaro and jaro-winkler. In this PR, I imported jaro, but this can be updated as needed.

stevemckenzie commented 10 months ago

Works for me!

jonrose-dev commented 9 months ago

We're running into this issue as well. Is there any timelines when this can be merged in and released?

0x80 commented 8 months ago

Looks very much like this project has been abandoned. Time fork and republish under a different scope name maybe. I am considering it.

Other than that, it seems that this PR made a mistake by adding the talisman as a dev dependency.

0x80 commented 7 months ago

@csp197 have you tried running the tests after your change? It seems 2 of them are failing

0x80 commented 7 months ago

I have forked and published a more modern version of this. I didn't yet add the Talisman replacement, because of the failing tests.

I am using this in a typescript project and didn't experience the bug #43 but possibly I'm using it differently.

See #47