search

finnjames / search-lights.vim

Search Lights for Vim/NeoVim
MIT License
0 stars 0 forks source link

Tokenization does not match VSCode extension #1

Open qualious opened 2 years ago

qualious commented 2 years ago

Hey again!

Thanks for taking the first step of implementing a vim colorscheme!

I came with feedback..

I created the same demo here on nvim and this is how it looks.

I normally use a modified version of spaceduck and this is how it looks

Let me know if you want me to provide any more information! Or I can also stop being lazy and contribute... but that's gotta wait until weekend I think.

finnjames commented 2 years ago

Please provide more information. Is the issue the tab background color?

qualious commented 2 years ago

Ah sorry for the late return, I missed this one.

I think the issue is the whole thing, the first image is nothing close to the actual colors that i see on search-lights. I linked the spaceduck as an example since while it includes things like common plugin colors that you might not know, it also correctly represents the intended colors. I figured maybe you are doing something wrong? I'm just trying to help sorry.

I can also modify something like spaceduck myself with your colors and publish it myself, or I don't know actually learn how theming works on vim and do it. but I figured you wouldn't be okay with that?

finnjames commented 2 years ago

Ahhhh I get what you're saying. That's actually a pretty big issue to solve because vscode and vim do not use the same tokenization scheme. I just used an existing vim theme template and moved the colors over. I will see what I can do to fix this but I am not sure when I will get the chance.

If you are interested in tackling this, just open templates/dark.colortemplate and mess around with the highlight groups until you find something that looks a little more like the vscode version. Then, just submit a pull request :)