search

finnmglas / Launcher

:rocket: A distraction-free minimal homescreen for Android.
https://play.google.com/store/apps/details?id=com.finnmglas.launcher
MIT License
152 stars 43 forks source link

Can't use custom theme #61

Open finnmglas opened 4 years ago

finnmglas commented 4 years ago

Describe the bug Launcher crashes after selecting an image

To Reproduce Steps to reproduce the behavior:

  1. Install from gplay
  2. Open settings
  3. Choose Image
  4. See it crashing.

Expected behavior Obviously no crashing.

Smartphone

Additional info Critical bug. Idk why. Shall fix soon.

finnmglas commented 4 years ago

Seems to be an API- related issue, as this does not occur on older APIs

finnmglas commented 4 years ago

Turns out, this issue is very specific and will not occur for regular users.

The Reason

I regularly clean my phones internal structure and deleted empty folders and useless files. So I came to also delete the storage/emulated/0/DCIM/Camera/ folder.

As Android expects this folder to exist, it will not check for its existence. Cropping images will then result in this problem.

Nils6852 commented 4 years ago

I always have this bug. I installed your app from F-Droid and have v1.5.0 When I go to settings>Launcher>"Hintergrund ändern" it open uo the gallery. Now I can choose a picture. Then I can crop it an klick "ok". After this klick there is a endless circle and says "Wird gespeichert...". To abort to save the image I go to Settings>apps>Launcher>Stopp erzwingen. After this steps I can normaly use the Launcher (whithout background)Screenshot_2020-10-17-09-10-26.png I hope you can help

finnmglas commented 4 years ago

Hey @Nils6852 !

The bug first occured to me because selecting /cropping an image in Laucher tries to save the cropped image in storage/emulated/0/DCIM/Camera/ and I deleted that folder on my device.

Likely your issue does not happen for this reason but has the same outcome - the app crashes when you try to select a background image.

I am sorry for the inconvenience and am going to re- open the issue until we resolve your bug.

I'll need some additional information from you though:

Thank you, we'll work on fixing it!

If anyone else has the same issue, please let us know so we can find out why.

Nils6852 commented 4 years ago

Hi, Thanks for this answer.

My device is LG G5 H580 Android 8.0.0 No, v1.5.0 is my first installed version. I just unlocked the bootloader, but the device is not rooted or use a custom rom.

finnmglas commented 4 years ago

Okay, good news:

I was able to reproduce the bug on a Samsung A51 and found out why Launcher crashes here:

In the SettingsActivity > Launcher Fragment, currently line 78, we use the deprecated method MediaStore.Images.Media.getBitmap(context!!.contentResolver, imageUri), which works up to around android API version 28.

This may help us fix it as soon as possible:

Nils6852 commented 3 years ago

Hi, I have fixed the problem by myself. I instalked an other gallery (simple mobile tools). Then I select a new picture and the Launcher show my selectet picture. The other gallery app is the stock LG gallery v.6.20.24 For me you can close the issue.

rptb1 commented 3 years ago

I created https://github.com/finnmglas/Launcher/issues/86 before I found this. I also do not have a DCIM/Camera folder, but that is going to be the case for all /e/OS users. The camera app on /e/OS is a derivative of OpenCamera, and stores pictures in DCIM/OpenCamera. There is no DCIM/Camera.

However, I tried creating DCIM/Camera and the crashing did not stop. I also cropped the same image from within the Gallery and it did not save to DCIM/Camera, but alongside the original. I also tried moving the original to DCIM/Camera but that made no difference. I don't know if these experiments are relevant but I thought I'd let you know my negative results!