search

finnvoor / fx-upscale

Metal-powered video upscaling
Creative Commons Zero v1.0 Universal
301 stars 10 forks source link

Upscaled 3D video doesn't have increased bitrate #19

Open Netruk44 opened 3 months ago

Netruk44 commented 3 months ago

I'm attempting to upscale a 3D movie from 1080p to 4k and I'm noticing that the output from fx-upscale can be blurrier than the input I'm giving it (when things with a lot of detail are in motion).

If I inspect the bitrate, the upscaled output video appears to be using the same bitrate as the input video file (edit: Or lower, even) . I would expect the upscaled video to have a higher bitrate than the input video to account for the increased resolution, no?

Edit again:

I started with a 100 GB 1080p MV-HEVC video file (encoded with way too high of a quality just to figure out where detail is getting lost), and after running it through fx-upscale it became a 15 GB 4K MV-HEVC.

Netruk44 commented 3 months ago

Manually specifying an output bit rate fix the issue for me, so I made a PR for what I did to accomplish that.

(I said this in the PR, but I'll repeat it here. Feel free to reject/close the pr without merging if you'd rather do something else to fix the issue)