finopsfoundation / focus_converters

Parent repository to hold all common documentation and code samples for all FOCUS Converter projects
MIT License
83 stars 44 forks source link

[proposed Enhancement] Feature Request to save graph rendering #142

Open csyvenky-finops opened 1 year ago

csyvenky-finops commented 1 year ago

In main.py, in the Explain function, can we plz add a line with similar functionality to this: image.save("out.jpeg", "JPEG")

In this way when explain is being called on the command line the graph rendering can be saved locally and will work in Codespaces environment.

varunmittal91 commented 11 months ago

Hi @csyvenky-finops, Added in #149, could you please give it a try. All you need to do is --image_path.

csyvenky-finops commented 11 months ago

Hi @varunmittal91, thanks for adding this new feature. I have a couple small concerns.

varunmittal91 commented 11 months ago

Thank you @csyvenky-finops that is good feedback, I will create another pr based on this.