ChargeSubcategory conversion leads to an impossible situation for AWS

finopsfoundation / focus_converters

Parent repository to hold all common documentation and code samples for all FOCUS Converter projects

MIT License

77 stars 43 forks source link

ChargeSubcategory conversion leads to an impossible situation for AWS #345

Open llp-devr opened 5 months ago

llp-devr commented 5 months ago

Describe the bug The file 1_charge_type_S001.yaml defines that : WHEN "lineItem/LineItemType" = 'BundledDiscount' THEN 'Usage'

But the file charge_sub_category_S001.yaml defines that: WHEN ChargeType = 'Adjustment' AND "lineItem/LineItemType" = 'BundledDiscount' THEN 'Credit'

The point is that based on the rule of the file 1_charge_type_S001.yaml, ChargeType will always be USAGE and ChargeSubcategory will never be Credit.

varunmittal91 commented 5 months ago

Thak you @llp-devr for pointing this out, if you could suggest a query or a fix, I will be happy to incorporate.