finos / FDC3-Sail

Open implementation of the FDC3 standard using Electron and an integrated App Directory.
Apache License 2.0
32 stars 20 forks source link

Returns the Intent result #137

Closed symphony-jean-michael closed 1 year ago

symphony-jean-michael commented 1 year ago

Changes

This PR adds some fixes to support GetResult from Intent of FDC3 v2.

Demo

Before the fix

Before the fix the intent Result was empty

Screenshot 2023-05-04 at 14 10 29

And in the logs of Sail the intent result was returned before the call to setIntentResult

Screenshot 2023-05-04 at 14 10 48-2

With the fix

With the fix the Intent result is correctly returned

Screenshot 2023-05-04 at 13 44 08

And you can see that a promise is returned for getIntentResult Screenshot 2023-05-04 at 13 44 30-2

symphony-jean-michael commented 1 year ago

Hello @nkolba I created this PR to support GetResult from Intent of FDC3 v2. It seems to me that maybe this can be linked to https://github.com/finos/FDC3-Sail/issues/73

Could you have a look on this PR ?

Thanks :)

nkolba commented 1 year ago

thanks @symphony-jean-michael ! This looks great. Will merge