finos / FDC3-conformance-framework

A framework for testing whether desktop containers implement the FDC3 standard
Apache License 2.0
14 stars 15 forks source link

Timeout and other fixes #122

Closed kriswest closed 2 years ago

kriswest commented 2 years ago

This PR addresses a problem in the open tests, where they should fail on an implementation defined timeout (FDC3 does not define the timeout only the error that should be thrown). As some apps in financial services can take an age to start-up/bootstrap themselves this is sometimes quite a long timeout. Further, we need messaging to explain it on a failure as if a DA uses a longer timeout the test will fail, but the DA may still be exhibiting correct behavior.

The PR also makes the package.json script work cross-platform. This was only tested on Windows PowerShell however (but has a much better chance of working elsewhere than the existing scripts) - please test!

Finally, please note that the timeout changes will be needed in the 2.0 implementation for both the open tests and RaiseIntent tests that also fail on a timeout when an intent listener of the desired type is not added. These are the relevant test ids in the 2.0 set that you will need to apply this approach to: