search

finos / FDC3-conformance-framework

A framework for testing whether desktop containers implement the FDC3 standard
Apache License 2.0
14 stars 15 forks source link

Fix V2 Metadata tests #167

Closed Joe-Dunleavy closed 1 year ago

Joe-Dunleavy commented 1 year ago

This fixes the v2 metadata tests.

New bugs had come to light after testing this against Finsemble's FDC3 2.0 implementation.

This PR should only be merged after the v2 intent tests PR has been merged in.

kriswest commented 1 year ago

@Joe-Dunleavy probably worth merging the release candidate branch into this one. If the diff doesn't clean up, close and recreate the PR using same branch and it should then. WIll be a lot easier to review once done

Joe-Dunleavy commented 1 year ago

@Joe-Dunleavy probably worth merging the release candidate branch into this one. If the diff doesn't clean up, close and recreate the PR using same branch and it should then. WIll be a lot easier to review once done

@kriswest This branch has already been merged with the release candidate. There shouldn't be any merge conflicts. Any changes here that aren't related to metadata tests are refactoring/cleaning up the import statements. There is one other change to the open-b mock app which was added to close the mock app window (see pic).

The test requires that no communication take place between the mock app and the test using the fdc3 API to close the mock app window.

I've removed this for now, as it didn't really solve the problem. We would be better off using localStorage instead to communicate to the mock app that it should run window.close once the test has completed.

I'll put in a separate issue for this. For now, leaving the mock app window open won't cause any problems because this is the only test that uses the open-b mock app.

image

robmoffat commented 1 year ago

can we merge this then?