search

finos / FDC3-conformance-framework

A framework for testing whether desktop containers implement the FDC3 standard
Apache License 2.0
14 stars 15 forks source link

2.0 Conformance: Issues in findIntents, private channel, and manual tests #261

Closed jupnit closed 2 months ago

jupnit commented 2 months ago

While running our Desktop Agent against 2.0 Conformance test framework, we noticed below 3 issues -

  1. v2.0/advanced/fdc3.findIntent.ts: The displayName for Intent.sharedTestingIntent2 and Intent.sharedTestingIntent1 needs to be updated to 'Shared Testing Intent 2' and 'Shared Testing Intent 1', respectively, as per local 2.0 app directory.

  2. v2.0/advanced/fdc3.raiseIntent.ts: We suggest adding a brief delay of ~200ms at line 118 after the context listeners are added, and before broadcasting the context to private channel, to ensure the Desktop Agent has sufficient time to initialize everything properly.

    image001

  3. Manual Tests: The TestTimeout of 20,000ms seems insufficient forfdc3ResolveAmbiguousContextTargetMultiInstance_2_0 and fdc3ResolveAmbiguousIntentTargetMultiInstance_2_0. These tests open four applications, then trigger a UI resolver app, which waits for user input before resolving. Given the dependency on user action, we think the timeout should be extended.

jupnit commented 2 months ago

Created a pull request with suggested fixes for these issues - #260