finos / FDC3

An open standard for the financial desktop.
https://fdc3.finos.org
Other
187 stars 109 forks source link

Correction to the 2.0 IntentResult? #1107

Closed openfin-johans closed 5 months ago

openfin-johans commented 7 months ago

The IntentResult in 2.1 includes the following:

type IntentResult = Context | Channel | void;

This was meant to be the case for 2.0 as well but was somehow not added in all the right places during the implementation/documentation of 2.0:

https://fdc3.finos.org/docs/2.0/api/ref/Types#intentresult

The 2.0 Conformance tests actually check for this particular behaviour and even though it's no longer the active version - it make sense to update the docs and the NPM packages to line up with the original intention rather then having it as a change in 2.1.

https://github.com/finos/FDC3-conformance-framework/blob/main/src/test/v2.0/advanced/fdc3.raiseIntent-Result.ts#L23