search

finos / FDC3

An open standard for the financial desktop.
https://fdc3.finos.org
Other
187 stars 109 forks source link

Add algolia search to Docusaurus website #1163

Closed maoo closed 3 months ago

netlify[bot] commented 4 months ago

Deploy Preview for fdc3 ready!

Name Link
Latest commit d8799a12c2a47efa67b8fa6120b92bab96fbeed3
Latest deploy log https://app.netlify.com/sites/fdc3/deploys/65f0656ed0bbdd000824ae0e
Deploy Preview https://deploy-preview-1163--fdc3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

robmoffat commented 3 months ago

Would be good to get some other maintainers to review before merging.

bingenito commented 3 months ago

I find the results very confusing since they include all versions of the API (for example, search for 'addContextListener'. I'm not sure it makes sense to only index the latest version so maybe it points to the need of different page titles?

kriswest commented 3 months ago

Could turn on contextual search, which will filter to the currently displayed version: https://docusaurus.io/docs/search#contextual-search

Otherwise, its a case of customisation and prominently displaying the version, and/or using custom facet filters. Probably best to try contextual search first as its easy to flip on

robmoffat commented 3 months ago

let's give it a whirl. Just made the change

bingenito commented 3 months ago

let's give it a whirl. Just made the change

+1 on this way.

robmoffat commented 3 months ago

yeah this looks good - merge?

kriswest commented 3 months ago

sure - will leave the joy or pushing the button to you ;-)

kriswest commented 3 months ago

Too late, pushed the button myself

kriswest commented 3 months ago

Thanks for the PR @maoo and @robmoffat