finos / FDC3

An open standard for the financial desktop.
https://fdc3.finos.org
Other
187 stars 109 forks source link

Add content guidelines and other tweaks to community page #1169

Closed kriswest closed 2 months ago

kriswest commented 3 months ago

This PR:

netlify[bot] commented 3 months ago

Deploy Preview for fdc3 ready!

Name Link
Latest commit 53e58187a5dd3a54da511ade77c30ac001a8aeec
Latest deploy log https://app.netlify.com/sites/fdc3/deploys/66150fb10f62fa0008783092
Deploy Preview https://deploy-preview-1169--fdc3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kriswest commented 3 months ago

@nkolba @robmoffat @finos/fdc3-maintainers Here's a crack at the discussed tweaks to the community page. I figured the easiest place to put the content guidelines is in the JSON file as that's what you see when you click on the "add your details" link.

If this is good with you, then we need to merge it and just lightly tweak Nick's PR to set the right categories, etc.

Happy to take suggestions on the guidelines, disclaimer etc., this is just an attempt to move us forward ;-)

Preview link: https://deploy-preview-1169--fdc3.netlify.app/community

kriswest commented 3 months ago

P.S. Implementation filters need rewriting in react at some point. The community page is currently rendered by a react functional component then hacked by some old JS I wrote for the static version in the docusaurus 2 site. There should be some state for the selected filter, which is then used to filter the rendered entries and highlight the selected filter.

The main downside currently is that the default filter is not shown as selected. Its possible it will develop other display artefacts later.

kriswest commented 3 months ago

From the last maintainers meeting:

Actions:

kriswest commented 2 months ago

Updated to take care of outstanding objectives:

Ready to merge

kriswest commented 2 months ago

@nkolba This is merged now, so if you could merge into your PR and check the content categories that should be good to go too