search

finos / FDC3

An open standard for the financial desktop.
https://fdc3.finos.org
Other
196 stars 116 forks source link

Remove the IntentResolution.version field as defunct #1170

Closed kriswest closed 5 months ago

kriswest commented 6 months ago

resolves #1053

Removed the version field from IntentResolution as there are no version fields for intents in the FDC3 API definitions and hence the field has no purpose.

netlify[bot] commented 6 months ago

Deploy Preview for fdc3 ready!

Name Link
Latest commit 0a53132bc12118b96d064bad990104a9d17d457a
Latest deploy log https://app.netlify.com/sites/fdc3/deploys/65eb07124a742a000832cb2f
Deploy Preview https://deploy-preview-1170--fdc3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bingenito commented 6 months ago

Does this need to be explicitly removed from markdown too?

https://github.com/finos/FDC3/blob/master/docs/api/ref/Metadata.md?plain=1#L324

kriswest commented 6 months ago

@bingenito Yes it does. You'd think I'd know how to do this by now 🤦‍♂️

kriswest commented 6 months ago

@bingenito fixed the docs reference, and a schema reference to the field that had made it into bridging.