search

finos / FDC3

An open standard for the financial desktop.
https://fdc3.finos.org
Other
187 stars 109 forks source link

Small bug in FDC3 Workbench, doesn't work with hierarchical classes. #1193

Closed robmoffat closed 2 months ago

netlify[bot] commented 2 months ago

Deploy Preview for fdc3 ready!

Name Link
Latest commit e1ad4a13b195b4f31832338a39884feb5b054586
Latest deploy log https://app.netlify.com/sites/fdc3/deploys/66214a0c321dde000823ce21
Deploy Preview https://deploy-preview-1193--fdc3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

robmoffat commented 2 months ago

Can you elaborate on this a hair - I think I understand but wanted to confirm. Is your IntentResult returned through the API extending another something else that's providing the getResult function (leading to hasOwnProperty not finding it)?

Approving as that code change is not going to hurt anything and would fix that above if that's whats happening

yes, that's right. I have a class, DefaultIntentResolution that implements IntentResolution , so the definition of getResult() is in the prototype.