search

finos / FDC3

An open standard for the financial desktop.
https://fdc3.finos.org
Other
187 stars 109 forks source link

Corrections to #1207 to fix broken tests #1236

Closed kriswest closed 3 days ago

kriswest commented 3 days ago

resolves #1234 by correcting deprecated JEST config resolves #1235 by adding missing addEventListener function to Methods.ts

netlify[bot] commented 3 days ago

Deploy Preview for fdc3 ready!

Name Link
Latest commit 5b3de393399e7f30c2377347b1d415d76f92abaa
Latest deploy log https://app.netlify.com/sites/fdc3/deploys/667d3e2484ea9b00083e2dcc
Deploy Preview https://deploy-preview-1236--fdc3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kriswest commented 3 days ago

@bingenito @finos/fdc3-maintainers here's a great example of why the tests should be required to pass before a PR can be merged. Somehow 4 of us looked at this and didn't see the npm-build tests failing! That's probably because they have not run and there was no failure to see:

https://github.com/finos/FDC3/actions/workflows/package.yml?query=is%3Afailure