finos / FDC3

An open standard for the financial desktop.
https://fdc3.finos.org
Other
193 stars 115 forks source link

GetAgent setWindowFDC3 parameter #1274

Closed robmoffat closed 6 days ago

robmoffat commented 1 month ago

We've been discussing whether the getAgent options should have a parameter for backwards compatibility which will set window.fdc3 and fire the fdc3Ready event. For pre-existing applications upgrading to FDC3 For the web and making heavy use of those features, this will save a lot of effort when upgrading to getAgent.

Question for discussion:

Should this parameter be set to true or false by default? i.e.

Some comments from email discussion:

@robmoffat said:

7/8. fdc3Ready/window.fdc3 - really this is coming down to what we set for the default then?

@kriswest said:

I reckon so. I've come to the conclusion that defaulting true will be make retrofit simpler and we like simple. I actually only think we need one option (if setting the global fire the event - they've always gone together in the past, so why separate em now - if you don't need the event, don't listen for it - its not going to hurt anything).

Derek Novavi then suggested that improving backwards compatibility would make FDC3 For The Web easier to accept when it comes to voting.

Thoughts?

Roaders commented 1 month ago

so does this mean that we are relaxing or removing the requirement to have window.fdc3 always set?

kriswest commented 1 month ago

@Roaders that is the plan, yes. By making setting it the default we can easily support existing.apps (that add only a getAgent call), and allow others to turn it off if they need to (they could also just ignore it).

Roaders commented 1 month ago

Great, that sounds good. I agree that defaulting to true makes the mast sense.

kriswest commented 1 month ago

I'll restart my opinion as confirmation. I think we should:

kriswest commented 6 days ago

Closed as decided and implemented