search

finos / FDC3

An open standard for the financial desktop.
https://fdc3.finos.org
Other
201 stars 132 forks source link

Clarify document while poc fdc3 #1314

Closed YaoYao-dd closed 2 months ago

YaoYao-dd commented 3 months ago

fix the code error in the PrivateChannel doc.

linux-foundation-easycla[bot] commented 3 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

netlify[bot] commented 3 months ago

Deploy Preview for fdc3 ready!

Name Link
Latest commit 164762b017e0e56b85ba805718243dc305f23aca
Latest deploy log https://app.netlify.com/sites/fdc3/deploys/66e1a4b28e584e000881537d
Deploy Preview https://deploy-preview-1314--fdc3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kriswest commented 3 months ago

/easycla

bingenito commented 2 months ago

/easycla

YaoYao-dd commented 2 months ago

LGTM - but needs a minor tweak in the changelog.

@YaoYao-dd do you know what you need to do get a CLA in place so that we can merge the PR? Start by clicking on the 'Please click here to be authorized' in the easyCLA comment on the PR. If you have any trouble @robmoffat or help@finos.org should be able to help.

Thanks, updated the changelog, now trying to pass easyCLA process, waiting for the approval, thanks.

YaoYao-dd commented 2 months ago

Thanks @kriswest ! can you please help to merge the PR, seems I don't have the access, could NOT find the 'merge' button, thanks.

kriswest commented 2 months ago

@YaoYao-dd all done - apologies I thought I'd done that yesterday!

YaoYao-dd commented 2 months ago

@kriswest Thanks!