finos / FDC3

An open standard for the financial desktop.
https://fdc3.finos.org
Other
201 stars 132 forks source link

Set explicit background colours for website #1361

Closed kriswest closed 2 months ago

kriswest commented 2 months ago

The website doesn't currently explicitly set background colors - rather it assume the browser's default background is white (which is a user preference in some browsers, while many electron-based products use a dark background by default - leaving the page impossible to read).

This PR sets an explicit background colour for each mode (dark and light)

netlify[bot] commented 2 months ago

Deploy Preview for fdc3 ready!

Name Link
Latest commit fb1d95445a00e1f9bfab41dbbc78a197dcab1c85
Latest deploy log https://app.netlify.com/sites/fdc3/deploys/66ec74bfb5948000079c852c
Deploy Preview https://deploy-preview-1361--fdc3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bingenito commented 2 months ago

Any thoughts on a bit lighter for dark theme like #1b1b1d? You can see with dark theme on docusaurus.io for an example.

kriswest commented 2 months ago

@bingenito adjusted to #1b1b1b, does seem a little less stark