Issue #14 : Configurable output

finos / JCurl

JSON-aware curl (1) in Java

Apache License 2.0

27 stars 24 forks source link

Issue #14 : Configurable output #15

Closed jeremp closed 1 year ago

jeremp commented 7 years ago

I've started working on the #14 issue.

I introduced two PrintStreams initialized by default to System.out and System.err. I replaced the references to System.out and System.err to the correct PrintStream.

I've seen that error output was used most of the time to display stuffs that, in my opinion, are not errors (request and response headers, response body, ... ). I think we could change it to use the standard output.

I thing printUsage() and printConfigSample() should keep on using System.out

ghost commented 7 years ago

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have you on file. In order for us to review and merge your code, please follow the directions at the link above. If you have questions or believe you've received this message in error, don't hesitate to contact Maurizio Pillitu (@maoo on github), our Devops Director.

CLA has not been signed by users @jeremp, @jeremp

ldrozdz commented 7 years ago

Closing due to CLA issues. Will reopen once those are resolved.

linux-foundation-easycla[bot] commented 1 year ago

:white_check_mark: login: ldrozdz / name: Łukasz Dróżdż (8b1be3b8f2ffb74c372836695d8e0e9737220a69, c0073a1e359c7a1d7cb8a17ccfa1251e38e895ba)
:x: - login: @jeremp / name: Jeremy Passeron . The commit (91b39735263d02e49cb5f4f0f6baf45d6710d5a5, 468cccbe8cde0186ae373b1ac9a48fe3c8dd443f, aea6289e30ce1712ed41c435b929f149eb06d3c4) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

ldrozdz commented 1 year ago

Reopening as https://github.com/finos/JCurl/pull/15 to fix CLA issues.