search

finos / a11y-theme-builder

DesignOps toolchain theme builder for accessibility inclusion using Atomic Design.
Apache License 2.0
43 stars 70 forks source link

[TB] "Hex Value" needs to have a dynamic color #837

Open literalEval opened 5 months ago

literalEval commented 5 months ago

Problem/Concern

Currently the Hex Value of the color is shown statically in black. This causes the shown value to 'disappear' for darker colors.

https://github.com/finos/a11y-theme-builder/assets/62198564/c7cadc89-f31c-47aa-ae1f-ab5601a3d32a

Proposed Solution

The Hex Value can have a dynamic color, perhaps the complementary color of the chosen one. This will ensure visibility in all cases. Other solutions also exist like moving the text to top or right, but that will require to have design changes.

PS: I tried theme builder from the demo web page

cooldude6000 commented 5 months ago

Can we just keep the background color the hex value constant ? i.e white or some other color? I think the issue will solved with this.

cooldude6000 commented 5 months ago

Also, can anyone point out where the code of this component is? So that I can start fixing it out.

literalEval commented 5 months ago

@gowreesh369 I would like to take this issue on fcfs basis. Please look for other good first issues. Thanks.

cooldude6000 commented 5 months ago

Sure thing!

literalEval commented 5 months ago

@PaulaPaul can you please assign this to me ? Thanks.

aaronreed708 commented 3 months ago

Hi @literalEval, I am so sorry that no one every replied to you on this issue. I just stumbled across it as a duplicate of #946 when I was reviewing that. Please let me know if you are still interested in contributing to this project. Again, I am so sorry that we weren't more responsive to your issue.