finos / a11y-theme-builder

DesignOps toolchain theme builder for accessibility inclusion using Atomic Design.
Apache License 2.0
41 stars 70 forks source link

[REQUEST] Show a pop-up if the user clicks on the "Show Theme" button before adding all the necessary colors #851

Open Photon3009 opened 4 months ago

Photon3009 commented 4 months ago

Suggestion/Concern

When users navigate to the color theme page and attempt to generate a theme template by clicking the "Show Theme" button without adding colors to all the required fields, the current behavior is to do nothing. This lack of feedback may lead to confusion for users who forget to fill in all the necessary color fields.

Proposed Solution

To improve user experience and provide guidance in such cases, we need to implement a feature that triggers a pop-up notification when the "Show Theme" button is clicked without all required colors being added. The pop-up should clearly convey to the user that colors must be added to all the mentioned fields before proceeding to display the theme template.

Photon3009 commented 4 months ago

@aaronreed708 I want to work on this, if this issue looks fine to you

aaronreed708 commented 4 months ago

@Photon3009 If you would like to add something for now, that is fine. But I believe that in the vision that @lwnoble has for the Color Theme going forward, there won't be a "Show Theme" button (see https://www.figma.com/file/qplg5PqoDAK6dh9Y58JlMD/Building-Themes?type=design&node-id=25-1927&mode=design&t=l7CIfAzJg5PA6FfD-0).