Adding highlight for the base color

finos / a11y-theme-builder

DesignOps toolchain theme builder for accessibility inclusion using Atomic Design.

Apache License 2.0

33 stars 68 forks source link

Closed omesh-omg closed 3 weeks ago

omesh-omg commented 4 weeks ago

this PR fixes issue #541

image of the drop down menu of color theme

image of the colorpalette(with show details turned off)

image of the colorpalette(with show details turned on)

netlify[bot] commented 4 weeks ago

Name	Link
Latest commit	edbc2a1f9deedf4e22e89a0bd45de600e1eadd75
Latest deploy log	https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/663a5f97820b7d0008c1613f
Deploy Preview	https://deploy-preview-852--glistening-gecko-6b417a.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aaronreed708 commented 3 weeks ago

@omesh-omg I tried this code using https://deploy-preview-852--glistening-gecko-6b417a.netlify.app/designSystem/testing541 and I think it looks pretty nice. @Chessel can you please verify that this meets your needs?

omesh-omg commented 3 weeks ago

Okay @aaronreed708 thanks for the review I will make the necessary changes, I was not familiar with these coding conventions before.

omesh-omg commented 3 weeks ago

hey @aaronreed708 I think I made the code neat and tidy now.

omesh-omg commented 3 weeks ago

Okay @aaronreed708 I will fix it I didn't think of it that way before.

aaronreed708 commented 3 weeks ago

forgot to mention, spoke with @Chessel yesterday, she tried out the changes and was happy with them.