18 Jul 2024 - A11y Theme Builder Meeting Minutes

[aaronreed708]

Date

2024-07-18 - 09:15am EDT

Zoom info

• Meeting link: https://zoom.us/j/91013899295?pwd=Qnh5UVN1aUZ4ak9tODgvMVNLNUg5Zz09
• Meeting id: 910 1389 9295
• Password: 123225
• Call-in: +1 929 205 6099 US (New York) (Check calendar for more options)

Untracked attendees

• Fullname, Affiliation, (optional) GitHub username
• ...

Meeting notices

• FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

• All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

• FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact legal@finos.org with any questions.

• FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

• [x] Convene & roll call (5mins)
• [x] Display FINOS Antitrust Policy summary slide
• [x] Review Meeting Notices (see above)
• [x] Approve past meeting minutes
• [x] Community WG Update (@PaulaPaul)
• [x] ESLint and Pre-commit hook discussion (@aaronreed708)
• [x] Discuss whether PenPot a viable way to get CSS from Figma (@aaronreed708)
• [x] ...
• [x] AOB, Q&A & Adjourn (5mins)

Minutes

• Paula updated us on the doings of the Community WG
  • gave us some background on the FINOS Tech Sprint that FINOS is trying to complete before FINOS OSFF NYC 2024 and how it applies to Theme Builder
    • Issue #961 opened to investigate how Theme Builder could possibly be used to improve accessibility in TraderX UI
    • TraderX work being tracked using https://github.com/finos/traderX/discussions/193
    • We will treat this as a real-world BYOD (Bring Your Own Design system) scenario to help us identify pain points for users
  • Badges for June have been submitted, should see them soon
  • Grace Hopper will have a dedicated breakout room for Theme Builder. Including Theme Builder, FINOS will have 3 breakout rooms. All are peer rooms, there is no FINOS parent room.
    • Oct 4th, 12pm-6:30pm EDT
    • We need to review the help wanted and good first issue issues to make sure that they are properly categorized for the Grace Hopper attendees, who likely will only spend a few hours on an issue
• Aaron highlighted the discussion we had this week around pre-commit vs pre-push hooks as they relate to prettify-ing and lint-ing the code
  • We decided that we'll go the pre-push route
  • We need to make sure that ESLint Errors (not warnings) will make the push fail
  • We will need to fine tune what is considered an error as we progress down this route
    • Aaron would like header warnings to be considered errors, for example.
  • We decided to push the lint changes that we have so far now. Will then make progress against the remaining lint errors over time. The remaining issues are a little more involved.
• Omesh gave update on the mentorship project. Static pages are nearing completion
  • Omesh and Aaron probably need to be brought in to SDK backend education/discussions so that we can start floating ideas on the changes necessary to support the frontend changes.
  • Aaron to get clarification from Lise w.r.t. being able to change dark mode colors

Decisions Made

• [x] We'll use a pre-push, not pre-commit, git hook for prettier and lint
• [x] We will push the lint changes that we have so far, will do the more involved changes over time
• [ ] ...

Action Items

• [ ] (from last week) Lise to get Omesh and Aaron CSS and responsive breakpoints and behaviors for #820 design
  • will provide CSS for framework only for now
• [ ] (from last week)Aaron and Evan need to break the Epic that will be worked on by the mentee into detailed and digestable issues
• [ ] (from last week) Lise to work with Aaron to update video in mkdocs documentation
• [x] Aaron to get clarification from Lise w.r.t. being able to change dark mode colors
• [x] Aaron to update pre-commit issue with decision
• [x] Aaron to push lint changes
• [ ] ...

[codyzu]

Cody Zuschlag - Nearform

[aaronreed708]

Aaron Reed - DFS Kathleen Burkhardt - BlackRock Omesh Kumawat Paula Paul - Greyshore

[budhathokipramin]

@aaronreed708 Hi I was unable to attend the meeting. I will attend it the next time.

[aaronreed708]

Approved in this week's meeting