search

finos / a11y-theme-builder

DesignOps toolchain theme builder for accessibility inclusion using Atomic Design.
Apache License 2.0
46 stars 69 forks source link

[TB] Multiple instances, hardcoded ids/labelids in Selectable editors causing accessibility issues #974

Closed kburk1997 closed 3 months ago

kburk1997 commented 4 months ago

Fixes #953.

Ensures all selectable editors have a unique id where IDs are being used. This allows each component with an id to have a correct accessible name. When duplicate IDs were used, accessible names could not be properly identified.

To test, run axe-devtools or Accessibility Insights for Web on a page that uses a Selectable component. Verify that aria-input-field-name error does not come up when running automated checks.

netlify[bot] commented 4 months ago

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
Latest commit 413e1651bd2cfa4abff3a04268a164406cca9d51
Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/66a2abe11d49b700087a7540
Deploy Preview https://deploy-preview-974--glistening-gecko-6b417a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.